http://codereview.chromium.org/17380/diff/5/6 File src/codegen-ia32.cc (right):
http://codereview.chromium.org/17380/diff/5/6#newcode4850 Line 4850: { On 2009/01/15 13:56:37, Kevin Millikin wrote: > Not sure why there's a block here? The enclosing switch statement jumps past the initialization of Label non_zero_product_mul when jumping to other cases, and the compiler complains. http://codereview.chromium.org/17380/diff/5/6#newcode4876 Line 4876: Label non_zero_product_div; On 2009/01/15 13:56:37, Kevin Millikin wrote: > The result of division is not a "product" :) Done. http://codereview.chromium.org/17380/diff/5/6#newcode4894 Line 4894: __ lea(reg_eax.reg(), Operand(eax, eax, times_1, kSmiTag)); On 2009/01/15 13:56:37, Kevin Millikin wrote: > Isn't this temp.reg()? They are the same in this case. Changed. Done. http://codereview.chromium.org/17380/diff/5/6#newcode4910 Line 4910: Label non_zero_product_mod; On 2009/01/15 13:56:37, Kevin Millikin wrote: > The result of mod, whatever it's called, is probably not a "product". Done. http://codereview.chromium.org/17380/diff/5/6#newcode4936 Line 4936: // Move right into ecx. On 2009/01/15 13:56:37, Kevin Millikin wrote: > Comment explaining why (because we will use a shift by cl encoding). Done. http://codereview.chromium.org/17380/diff/5/6#newcode4993 Line 4993: JumpTarget shr_result_ok(generator()); On 2009/01/15 13:56:37, Kevin Millikin wrote: > Is it safe to make this a raw Label, because there is no frame effect that needs > to be merged on either path? Otherwise, you will need a temp.ToRegister for > safety below just before the lea instruction. Yes. http://codereview.chromium.org/17380/diff/5/6#newcode5009 Line 5009: Result smi_test_reg = generator()->allocator()->Allocate(); On 2009/01/15 13:56:37, Kevin Millikin wrote: > Throw in an assert that this register is valid for safety. Done. http://codereview.chromium.org/17380 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
