Reviewers: William Hesse, Mads Ager,

Message:
The default argument actually seems more explicit, because the backward
edges stand out more when reading the code.

Description:
Experimental: statically distinguish between named basic block entries
that are definitely reached by only forward CFG edges and those that
may be reached by a backward edge.  Assert that we do not try to jump
backward to forward-only blocks.  Otherwise, the two types of blocks
are not handled differently yet.

There are only a handful of backward edges:
  * one for each of the loop types (while, for, and do...while),
  * the for...in statement,
  * a loop in GenerateFastCharCodeAt,
  * the fall-through from a default case in a switch when it is not the
    last case,
  * (possibly) the return sequence
  * the exit labels from deferred code

The last two are not true backward edges (there is no loop).

Please review this at http://codereview.chromium.org/18362

SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/

Affected files:
   M     src/codegen-ia32.cc
   M     src/codegen.cc
   M     src/jump-target-ia32.cc
   M     src/jump-target.h



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to