http://codereview.chromium.org/18363/diff/1/6 File src/bytecodes-irregexp.h (right):
http://codereview.chromium.org/18363/diff/1/6#newcode40 Line 40: V(BREAK, 0, 4) /* bc8 */ \ On 2009/01/20 14:22:17, Christian Plesner Hansen wrote: > Why not count in whole words? Unfortunately, the Label class counts in bytes and so this is rather a large change to make. I agree it would be cleaner, but I'm going to save it for another change. http://codereview.chromium.org/18363/diff/1/3 File src/regexp-macro-assembler-irregexp-inl.h (right): http://codereview.chromium.org/18363/diff/1/3#newcode39 Line 39: void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte, uint32_t twenty_four_bits) { On 2009/01/20 14:22:17, Christian Plesner Hansen wrote: > Maybe assert that twenty_four_bits does indeed only use 24 bits? Right now we don't check so the assert would not always be true (though it always is for any sensible regexp). I will add the assert when I add the check (it's on the TODO list). http://codereview.chromium.org/18363 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
