[v8-dev] Fixes for assumption of sizeof(int) == sizeof(void*)

[Jeff Bailey]

Hi!  There seem to be a number of places that assume that a pointer is
the same size as an int (or an ILP32 system in general).  Will fixes
like this be accepted?

2009-01-20  Jeff Bailey <jeffbai...@google.com>

        * src/checks.h: Use %p modifier for displaying pointers.

Index: src/checks.h
===================================================================
--- src/checks.h        (revision 1112)
+++ src/checks.h        (working copy)
@@ -136,9 +136,9 @@
                                      void* value) {
   if (expected != value) {
     V8_Fatal(file, line,
-             "CHECK_EQ(%s, %s) failed\n#   Expected: %i\n#   Found:
%i",
+             "CHECK_EQ(%s, %s) failed\n#   Expected: %p\n#   Found:
%p",
              expected_source, value_source,
-             reinterpret_cast<int>(expected), reinterpret_cast<int>
(value));
+             expected, value);
   }
 }

@@ -150,8 +150,8 @@
                                         const char* value_source,
                                         void* value) {
   if (expected == value) {
-    V8_Fatal(file, line, "CHECK_NE(%s, %s) failed\n#   Value: %i",
-             expected_source, value_source, reinterpret_cast<int>
(value));
+    V8_Fatal(file, line, "CHECK_NE(%s, %s) failed\n#   Value: %p",
+             expected_source, value_source, value);
   }
 }


--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---