Thanks! > http://codereview.chromium.org/18660/diff/8/208 > File src/runtime.cc (right): > > http://codereview.chromium.org/18660/diff/8/208#newcode836 > Line 836: // Set it if it is not a read_only property. > read-only with a - instead of _?
Done. > http://codereview.chromium.org/18660/diff/8/208#newcode841 > Line 841: // need to convert back to excpetions here. > exceptions Done. > http://codereview.chromium.org/18660/diff/8/206 > File test/mjsunit/const.js (right): > > http://codereview.chromium.org/18660/diff/8/206#newcode55 > Line 55: assertEquals(1, valueOfCount); > I wonder why this was zero before? It seems to contradict the comment. That test was completely broken and the code was never run. What is there now makes a lot of sense to me. http://codereview.chromium.org/18660 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
