http://codereview.chromium.org/18551/diff/1/2 File src/codegen-ia32.cc (right):
http://codereview.chromium.org/18551/diff/1/2#newcode1129 Line 1129: __ shl(ebx, shift_value); It's late in the day so I could be wrong. Do we really need to shift right kSmiTagSize, shift left shift_value, and then shift left kSmiTagSize to reapply the tag? Analogous to a multiply, can't we just shift the tagged value if the tag is zero? http://codereview.chromium.org/18551 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
