Lgtm, except for the poorly named and/or documented TryFlattenNoInlineCheck.
http://codereview.chromium.org/18552/diff/1/4 File src/objects.h (right): http://codereview.chromium.org/18552/diff/1/4#newcode3138 Line 3138: Object* TryFlattenNoInlineCheck(StringShape shape); If this always flattens, why is it called TryFlatten? Also, it's not obvious to me from the documentation what NoInlineCheck signifies. http://codereview.chromium.org/18552/diff/1/4#newcode3140 Line 3140: // Try to flatten the string. Checks first inline to see if it is necessary. I can't parse the second sentence -- what does "checks first inline" mean? http://codereview.chromium.org/18552 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
