OK, I've been through it. Just a few comments or questions.
http://codereview.chromium.org/18669/diff/203/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/18669/diff/203/3#newcode1087 Line 1087: if (shift_value < 2) { This needs a comment so that 2 doesn't seem so magic. http://codereview.chromium.org/18669/diff/203/3#newcode1092 Line 1092: // tag result and store it in TOS (eax) Remove this comment. http://codereview.chromium.org/18669/diff/203/3#newcode1112 Line 1112: new DeferredInlinedSmiOperation(this, Token::SHL, smi_value, Smi::FromInt(shift_value)? http://codereview.chromium.org/18669/diff/203/3#newcode1124 Line 1124: } else if (shift_value > 1) { Is this an "else if" or a simple else (possibly with an assert that shift_value > 1)? http://codereview.chromium.org/18669/diff/203/3#newcode1127 Line 1127: // Convert int result to Smi, checking that it is in int range. Is it possible to just shift the smi-tagged value, rather than untagging, shifting, and retagging? http://codereview.chromium.org/18669 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
