Reviewers: William Hesse, Description: Cleanup the rest of the experimental sources by filing issues and noting them in TODOs.
Please review this at http://codereview.chromium.org/18745 SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ Affected files: M src/jump-target-ia32.cc M src/jump-target.h M src/virtual-frame-ia32.cc Index: src/virtual-frame-ia32.cc =================================================================== --- src/virtual-frame-ia32.cc (revision 1142) +++ src/virtual-frame-ia32.cc (working copy) @@ -424,7 +424,7 @@ } // At this point, the frames should be identical. - // TODO(): Consider an "equals" method for frames. + // TODO(208): Consider an "equals" method for frames. ASSERT(stack_pointer_ == expected->stack_pointer_); #ifdef DEBUG for (int i = 0; i < elements_.length(); i++) { @@ -819,7 +819,7 @@ elements_[index] = top; if (top.is_memory()) { - // TODO(): consider allocating the slot to a register. + // TODO(209): consider allocating the slot to a register. // // Emit code to store memory values into the required frame slot. Result temp = cgen_->allocator()->Allocate(); Index: src/jump-target-ia32.cc =================================================================== --- src/jump-target-ia32.cc (revision 1142) +++ src/jump-target-ia32.cc (working copy) @@ -121,9 +121,9 @@ // backward edge. We negate the condition and emit the merge code // here. // - // TODO(): we should try to avoid negating the condition in the case - // where there is no merge code to emit. Otherwise, we emit a - // branch around an unconditional jump. + // TODO(210): we should try to avoid negating the condition in the + // case where there is no merge code to emit. Otherwise, we emit + // a branch around an unconditional jump. ASSERT(direction_ == BIDIRECTIONAL); Label original_fall_through; __ j(NegateCondition(cc), &original_fall_through, NegateHint(hint)); Index: src/jump-target.h =================================================================== --- src/jump-target.h (revision 1142) +++ src/jump-target.h (working copy) @@ -35,8 +35,6 @@ // ------------------------------------------------------------------------- // Jump targets // -// TODO(): Update this comment. -// // A jump target is an abstraction of a basic-block entry in generated // code. It collects all the virtual frames reaching the block by // forward jumps and pairs them with labels for the merge code along --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
