Author: [email protected]
Date: Mon Jan 26 02:44:18 2009
New Revision: 1147
Modified:
branches/experimental/toiger/src/jump-target-ia32.cc
branches/experimental/toiger/src/jump-target.h
branches/experimental/toiger/src/virtual-frame-ia32.cc
Log:
Cleanup the rest of the experimental sources by filing issues and
noting them in TODOs.
Review URL: http://codereview.chromium.org/18745
Modified: branches/experimental/toiger/src/jump-target-ia32.cc
==============================================================================
--- branches/experimental/toiger/src/jump-target-ia32.cc (original)
+++ branches/experimental/toiger/src/jump-target-ia32.cc Mon Jan 26
02:44:18 2009
@@ -121,9 +121,9 @@
// backward edge. We negate the condition and emit the merge code
// here.
//
- // TODO(): we should try to avoid negating the condition in the case
- // where there is no merge code to emit. Otherwise, we emit a
- // branch around an unconditional jump.
+ // TODO(210): we should try to avoid negating the condition in the
+ // case where there is no merge code to emit. Otherwise, we emit
+ // a branch around an unconditional jump.
ASSERT(direction_ == BIDIRECTIONAL);
Label original_fall_through;
__ j(NegateCondition(cc), &original_fall_through, NegateHint(hint));
Modified: branches/experimental/toiger/src/jump-target.h
==============================================================================
--- branches/experimental/toiger/src/jump-target.h (original)
+++ branches/experimental/toiger/src/jump-target.h Mon Jan 26 02:44:18 2009
@@ -35,8 +35,6 @@
//
-------------------------------------------------------------------------
// Jump targets
//
-// TODO(): Update this comment.
-//
// A jump target is an abstraction of a basic-block entry in generated
// code. It collects all the virtual frames reaching the block by
// forward jumps and pairs them with labels for the merge code along
Modified: branches/experimental/toiger/src/virtual-frame-ia32.cc
==============================================================================
--- branches/experimental/toiger/src/virtual-frame-ia32.cc (original)
+++ branches/experimental/toiger/src/virtual-frame-ia32.cc Mon Jan 26
02:44:18 2009
@@ -424,7 +424,7 @@
}
// At this point, the frames should be identical.
- // TODO(): Consider an "equals" method for frames.
+ // TODO(208): Consider an "equals" method for frames.
ASSERT(stack_pointer_ == expected->stack_pointer_);
#ifdef DEBUG
for (int i = 0; i < elements_.length(); i++) {
@@ -819,7 +819,7 @@
elements_[index] = top;
if (top.is_memory()) {
- // TODO(): consider allocating the slot to a register.
+ // TODO(209): consider allocating the slot to a register.
//
// Emit code to store memory values into the required frame slot.
Result temp = cgen_->allocator()->Allocate();
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
