Reviewers: Mads Ager, Description: Fixing alignment issue allowing serialization to run on ARM.
Please review this at http://codereview.chromium.org/18746 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/serialize.cc M test/cctest/cctest.status Index: test/cctest/cctest.status =================================================================== --- test/cctest/cctest.status (revision 1144) +++ test/cctest/cctest.status (working copy) @@ -33,7 +33,10 @@ [ $arch == arm ] test-debug: SKIP -test-serialize: SKIP +test-serialize/Deserialize: SKIP +test-serialize/DeserializeAndRunScript: SKIP +test-serialize/DeserializeNatives: SKIP +test-serialize/DeserializeExtensions: SKIP # BUG(113): Test seems flaky on ARM. test-spaces/LargeObjectSpace: PASS || FAIL Index: src/serialize.cc =================================================================== --- src/serialize.cc (revision 1145) +++ src/serialize.cc (working copy) @@ -814,8 +814,7 @@ void Update(Address start_address) { for (int i = 0; i < offsets_.length(); i++) { - Address* p = reinterpret_cast<Address*>(start_address + offsets_[i]); - *p = addresses_[i]; + memcpy(start_address + offsets_[i], &addresses_[i], sizeof(Address)); } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
