It is no longer jumping into spilled code when the changes in http://codereview.chromium.org/18669/show are applied. Should I take the move of of DeferredInlinedSmiOperation:Generate outside of the class definition and put it in that changelist instead, so it doesn't conflict with the changes made to Generate in that changelist?
On Mon, Jan 26, 2009 at 11:36 AM, <[email protected]> wrote: > > http://codereview.chromium.org/18742/diff/1/2 > File src/codegen-ia32.cc (left): > > http://codereview.chromium.org/18742/diff/1/2#oldcode846 > Line 846: exit()->Jump(); > On 2009/01/26 10:07:50, William Hesse wrote: > >> The other change list returns a result through Jump(&result), as is >> > done the > >> deferred addition and subtraction cases. >> Should that be done here, or when the change is merged in? >> > > This is spilled code jumping into spilled code, so I won't bother. > > > http://codereview.chromium.org/18742 > -- We can IMAGINE what is not --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
