Reviewers: Mads Ager, Description: Reintroduced a fix for an alignment issue on ARM. I had reverted it by mistake. This fixes the serialization test suite on ARM.
Please review this at http://codereview.chromium.org/18751 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/serialize.h M test/cctest/cctest.status Index: test/cctest/cctest.status =================================================================== --- test/cctest/cctest.status (revision 1150) +++ test/cctest/cctest.status (working copy) @@ -33,10 +33,6 @@ [ $arch == arm ] test-debug: SKIP -test-serialize/Deserialize: SKIP -test-serialize/DeserializeAndRunScript: SKIP -test-serialize/DeserializeNatives: SKIP -test-serialize/DeserializeExtensions: SKIP # BUG(113): Test seems flaky on ARM. test-spaces/LargeObjectSpace: PASS || FAIL Index: src/serialize.h =================================================================== --- src/serialize.h (revision 1150) +++ src/serialize.h (working copy) @@ -225,8 +225,8 @@ } int GetInt() { - int result = *reinterpret_cast<const int*>(str_); - str_ += sizeof(result); + int result; + GetBytes(reinterpret_cast<Address>(&result), sizeof(result)); return result; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
