Author: olehougaard
Date: Mon Jan 26 03:33:12 2009
New Revision: 1149

Modified:
    branches/bleeding_edge/src/serialize.cc
    branches/bleeding_edge/test/cctest/cctest.status

Log:
Fixing alignment issue allowing serialization to run on ARM.
Review URL: http://codereview.chromium.org/18746

Modified: branches/bleeding_edge/src/serialize.cc
==============================================================================
--- branches/bleeding_edge/src/serialize.cc     (original)
+++ branches/bleeding_edge/src/serialize.cc     Mon Jan 26 03:33:12 2009
@@ -814,8 +814,7 @@

    void Update(Address start_address) {
      for (int i = 0; i < offsets_.length(); i++) {
-      Address* p = reinterpret_cast<Address*>(start_address + offsets_[i]);
-      *p = addresses_[i];
+      memcpy(start_address + offsets_[i], &addresses_[i], sizeof(Address));
      }
    }


Modified: branches/bleeding_edge/test/cctest/cctest.status
==============================================================================
--- branches/bleeding_edge/test/cctest/cctest.status    (original)
+++ branches/bleeding_edge/test/cctest/cctest.status    Mon Jan 26 03:33:12  
2009
@@ -33,7 +33,10 @@
  [ $arch == arm ]

  test-debug: SKIP
-test-serialize: SKIP
+test-serialize/Deserialize: SKIP
+test-serialize/DeserializeAndRunScript: SKIP
+test-serialize/DeserializeNatives: SKIP
+test-serialize/DeserializeExtensions: SKIP

  # BUG(113): Test seems flaky on ARM.
  test-spaces/LargeObjectSpace: PASS || FAIL

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to