Reviewers: Mads Ager, olehougaard,

Message:
This change is kinda ugly, but this code was ugly before I got to it.
This function was the second largest function in a release build of
Google Chrome.

Description:
Reduce the size of a release sample shell by 55k.

The ExternalReferenceTable population code was code driven, using the
list macro callbacks to call an Add() function.  Additionally this Add()
function was defined in the class defintion, making it inline.  This
caused this single function to be ~100k of code.  It is now mostly table
driven, but there are still some cases left as code, and these could be
improved in the future for further reduction in binary size.

Please review this at http://codereview.chromium.org/18761

Affected files:
   M src/serialize.cc



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to