On 1/26/09, [email protected] <[email protected]> wrote: > Reviewers: Erik Corry, > > Message: > Quick review for a quick bugfix. > > Description: > A field might be incorrectly set, causing registers to be pushed and > popped > instead of just cleared on backtrack - or, worse, the other way around! > > Please review this at http://codereview.chromium.org/18590 > > Affected files: > M src/jsregexp.h > > > Index: src/jsregexp.h > diff --git a/src/jsregexp.h b/src/jsregexp.h > index > 959edddb187890e89e9bee5e3c4074f28348debb..7f1f01f83e071bc109a8a4c8536ae795eb17a81d > > 100644 > --- a/src/jsregexp.h > +++ b/src/jsregexp.h > @@ -1105,7 +1105,8 @@ class Trace { > public: > DeferredCapture(int reg, bool is_capture, Trace* trace) > : DeferredAction(ActionNode::STORE_POSITION, reg), > - cp_offset_(trace->cp_offset()) { } > + cp_offset_(trace->cp_offset()), > + is_capture_(is_capture) { } > int cp_offset() { return cp_offset_; } > bool is_capture() { return is_capture_; } > private: > > > lgtm!
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
