Reviewers: William Hesse, Description: Remove the unused, inaptly-named, and incorrect RequiresMergeCode.
Please review this at http://codereview.chromium.org/19661 SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ Affected files: M src/virtual-frame-ia32.h M src/virtual-frame-ia32.cc Index: src/virtual-frame-ia32.cc =================================================================== --- src/virtual-frame-ia32.cc (revision 1182) +++ src/virtual-frame-ia32.cc (working copy) @@ -273,35 +273,6 @@ } -bool VirtualFrame::RequiresMergeCode() { - // A frame requires code to be generated to make the frame mergable if - // there are duplicated non-synched registers or else valid elements not - // in a (memory or register) location in the frame. We look for valid - // non-synced non-location elements and count occurrences of non-synced - // registers. - RegisterFile non_synced_regs; - for (int i = 0; i < elements_.length(); i++) { - FrameElement element = elements_[i]; - if (element.is_valid() && !element.is_synced()) { - if (element.is_register()) { - non_synced_regs.Use(elements_[i].reg()); - } else if (!element.is_memory()) { - // Not memory or register and not synced. - return true; - } - } - } - - for (int i = 0; i < RegisterFile::kNumRegisters; i++) { - if (non_synced_regs.count(i) > 1) { - return true; - } - } - - return false; -} - - void VirtualFrame::MakeMergable() { Comment cmnt(masm_, "[ Make frame mergable"); // We should always be merging the code generator's current frame to an Index: src/virtual-frame-ia32.h =================================================================== --- src/virtual-frame-ia32.h (revision 1182) +++ src/virtual-frame-ia32.h (working copy) @@ -206,9 +206,6 @@ // (ie, they all have frame-external references). Register SpillAnyRegister(); - // True if making the frame mergable via MakeMergable will generate code. - bool RequiresMergeCode(); - // Ensure that this frame is in a state where an arbitrary frame of the // right size could be merged to it. May emit code. void MakeMergable(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
