Reviewers: plesner, Message: Very short review. Fixes difference from WebKit as detected by layout test.
Description: Added check for invalid repetition in RegExp parser Please review this at http://codereview.chromium.org/19663 Affected files: M src/parser.cc Index: src/parser.cc diff --git a/src/parser.cc b/src/parser.cc index 333f1c7af40ce25d9738d6434e355f70c6bab939..9f1cc150d76ab3873080f775ddc38944e2b5fa07 100644 --- a/src/parser.cc +++ b/src/parser.cc @@ -3788,6 +3788,10 @@ RegExpTree* RegExpParser::ParseDisjunction() { break; case '{': if (ParseIntervalQuantifier(&min, &max)) { + if (max < min) { + ReportError(CStrVector("numbers out of order in {} quantifier.") + CHECK_FAILED); + } break; } else { continue; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
