75% of the time was taken up by the 3-4 unshift calls on the 40000-large non-array and looking at the implementation it's obvious why that is.
On Mon, Feb 2, 2009 at 8:06 PM, Erik Corry <[email protected]> wrote: > On Mon, Feb 2, 2009 at 5:31 PM, <[email protected]> wrote: >> Reviewers: Erik Corry, >> >> Description: >> Turned down the amount of work done by array-splice to ensure that it >> doesn't time out on our slowest platforms. It turns out that almost >> all the time was spent in Array.prototype.unshift on a non-array with >> a length-field holding 40000. We may want to look into that but on >> the other hand it is a pretty obscure thing to do so we may not. > > If you are sure that it is the 40000 and not the VERYLARGE that is > causing most of the work then this LGTM. > > -- > Erik Corry, Software Engineer > Google Denmark ApS. CVR nr. 28 86 69 84 > c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 > Copenhagen K, Denmark. > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
