Reviewers: Erik Corry, Description: Turned down the amount of work done by array-splice to ensure that it doesn't time out on our slowest platforms. It turns out that almost all the time was spent in Array.prototype.unshift on a non-array with a length-field holding 40000. We may want to look into that but on the other hand it is a pretty obscure thing to do so we may not.
Please review this at http://codereview.chromium.org/19540 Affected files: M test/mjsunit/array-splice.js Index: test/mjsunit/array-splice.js diff --git a/test/mjsunit/array-splice.js b/test/mjsunit/array-splice.js index b5e85c6e1380c0a0a8aedeb6115d02f7ce44d2f0..d308ef569d83a6c27af19242d4acac7f44049d21 100644 --- a/test/mjsunit/array-splice.js +++ b/test/mjsunit/array-splice.js @@ -45,7 +45,7 @@ function PseudoArray() { }; for (var use_real_arrays = 0; use_real_arrays <= 1; use_real_arrays++) { - var poses = [0, 140, 40000, VERYLARGE]; + var poses = [0, 140, 20000, VERYLARGE]; var the_prototype; var new_function; var push_function; @@ -309,5 +309,3 @@ Array.prototype[1] = 1; assertEquals(1, arr.pop()); assertEquals(0, arr.pop()); Array.prototype[1] = undefined; - - --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
