LGTM On Tue, Feb 3, 2009 at 2:31 PM, <[email protected]> wrote: > Reviewers: Erik Corry, > > Message: > Tiny review, please. > > Description: > RegExp: Small bugfix in debug mode. > > Please review this at http://codereview.chromium.org/21014 > > Affected files: > M src/jsregexp.cc > > > Index: src/jsregexp.cc > diff --git a/src/jsregexp.cc b/src/jsregexp.cc > index > c737b027195cbb96c2f4bb0a0f3234ad5a6fda90..c827063ef7d790cc1240f8b3de2b31b2e143f62f > 100644 > --- a/src/jsregexp.cc > +++ b/src/jsregexp.cc > @@ -1507,12 +1507,7 @@ void > Trace::PerformDeferredActions(RegExpMacroAssembler* assembler, > void Trace::Flush(RegExpCompiler* compiler, RegExpNode* successor) { > RegExpMacroAssembler* assembler = compiler->macro_assembler(); > > - ASSERT(actions_ != NULL || > - cp_offset_ != 0 || > - backtrack() != NULL || > - characters_preloaded_ != 0 || > - quick_check_performed_.characters() != 0 || > - bound_checked_up_to_ != 0); > + ASSERT(!is_trivial()); > > if (actions_ == NULL && backtrack() == NULL) { > // Here we just have some deferred cp advances to fix and we are back to > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
