Author: [email protected]
Date: Wed Feb 4 03:36:30 2009
New Revision: 1222
Modified:
branches/bleeding_edge/src/debug-delay.js
Log:
Minor debugger cleanup. Store the running state of the previous debugger
response to avoid having to parse the just generated JSON response just to
pick out the running state. Also removed an unused function.
Review URL: http://codereview.chromium.org/20039
Modified: branches/bleeding_edge/src/debug-delay.js
==============================================================================
--- branches/bleeding_edge/src/debug-delay.js (original)
+++ branches/bleeding_edge/src/debug-delay.js Wed Feb 4 03:36:30 2009
@@ -945,6 +945,7 @@
function DebugCommandProcessor(exec_state) {
this.exec_state_ = exec_state;
+ this.running_ = false;
};
@@ -953,11 +954,6 @@
}
-DebugCommandProcessor.prototype.responseIsRunning = function (response) {
- return this.isRunning(response);
-}
-
-
function ResponsePacket(request) {
// Build the initial response from the request.
this.seq = next_response_seq++;
@@ -1032,7 +1028,7 @@
};
-DebugCommandProcessor.prototype.processDebugJSONRequest =
function(json_request, stopping) {
+DebugCommandProcessor.prototype.processDebugJSONRequest =
function(json_request) {
var request; // Current request.
var response; // Generated response.
try {
@@ -1091,10 +1087,7 @@
// Return the response as a JSON encoded string.
try {
- // Set the running state to what indicated.
- if (!IS_UNDEFINED(stopping)) {
- response.running = !stopping;
- }
+ this.running_ = response.running; // Store the running state.
return response.toJSONProtocol();
} catch (e) {
// Failed to generate response - return generic error.
@@ -1538,18 +1531,10 @@
};
-// Check whether the JSON response indicate that the VM should be running.
-DebugCommandProcessor.prototype.isRunning = function(json_response) {
- try {
- // Convert the JSON string to an object.
- response = %CompileString('(' + json_response + ')', 0)();
-
- // Return whether VM should be running after this request.
- return response.running;
-
- } catch (e) {
- return false;
- }
+// Check whether the previously processed command caused the VM to become
+// running.
+DebugCommandProcessor.prototype.isRunning = function() {
+ return this.running_;
}
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
