http://codereview.chromium.org/21076/diff/1/5 File src/d8.js (right):
http://codereview.chromium.org/21076/diff/1/5#newcode106 Line 106: if (event.eventType() == Debug.DebugEvent.Break) { On 2009/02/05 09:56:40, Mads Ager wrote: > How about a switch on the event type instead? Done. http://codereview.chromium.org/21076/diff/1/2 File test/mjsunit/debug-compile-event.js (right): http://codereview.chromium.org/21076/diff/1/2#newcode1 Line 1: // Copyright 2008 the V8 project authors. All rights reserved. On 2009/02/05 09:56:40, Mads Ager wrote: > 2009 Done. http://codereview.chromium.org/21076/diff/1/2#newcode35 Line 35: On 2009/02/05 09:56:40, Mads Ager wrote: > Why put spaces here and not before the function? Tried to indicate that these variables where set by the function. Did not work. Changed formatting and added comments. http://codereview.chromium.org/21076 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
