LGTM - I'm looking forward to the jump-target-triple abstraction... On Thu, Feb 5, 2009 at 11:43 AM, <[email protected]> wrote: > Reviewers: William Hesse, Kasper Lund, > > Message: > This is a little complicated. > > As another change, I plan to abstract the triple of jump targets into a > single class with the branching behavior and the state to tell if > they've been used. > > Description: > Experimental: improve the code generated for possibly boolean-valued > expressions. > > Instead of branching to the true control target and jumping to the > false one, track which one is the preferred fall-through. Use this to > branch to the non-fall-through and bind the fall-through. This avoids > a jump to the next instruction or else a branch around a jump. > > It becomes more difficult to tell if we have compiled an expression > into control flow or not. > > Please review this at http://codereview.chromium.org/21077 > > SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ > > Affected files: > M src/codegen-ia32.h > M src/codegen-ia32.cc > M src/disassembler.cc > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
