http://codereview.chromium.org/20257/diff/1/2
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/20257/diff/1/2#newcode666
Line 666: if (source.is_register() && target.is_register()) {
What is the precondition on the frame and expected frame re. copies, for
MergeTo to work?  We are clearly not handling all cases of copies here,
are we?

http://codereview.chromium.org/20257/diff/1/2#newcode795
Line 795: EmitPush(esi);
I didn't know we were keeping EmitPush().  Which of the functions used
while converting to unspilled frames are we going to keep?

http://codereview.chromium.org/20257

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to