Reviewers: Kevin Millikin, Message: Small fix.
Description: Fix reversed arguments in comparison to a smi constant. Please review this at http://codereview.chromium.org/20420 SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ Affected files: M src/codegen-ia32.cc Index: src/codegen-ia32.cc =================================================================== --- src/codegen-ia32.cc (revision 1291) +++ src/codegen-ia32.cc (working copy) @@ -1305,8 +1305,8 @@ // Setup and call the compare stub, which expects arguments in edx // and eax. CompareStub stub(cc, strict); - left_side.ToRegister(eax); - right_side.ToRegister(edx); + left_side.ToRegister(edx); // Only left_side currently uses a register. + right_side.ToRegister(eax); // left_side is not in eax. eax is free. Result result = frame_->CallStub(&stub, &left_side, &right_side, 0); result.ToRegister(); __ cmp(result.reg(), 0); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
