LGTM I see no problems here, except nits.
http://codereview.chromium.org/21410/diff/1/5 File src/log.cc (right): http://codereview.chromium.org/21410/diff/1/5#newcode676 Line 676: code->instruction_size() + Code::kHeaderSize); nit: maybe extract a method here, as code gets repeated http://codereview.chromium.org/21410/diff/1/2 File tools/tickprocessor.py (right): http://codereview.chromium.org/21410/diff/1/2#newcode153 Line 153: # Falg indicating whether to ignore unaccounted ticks in the report typo: Flag http://codereview.chromium.org/21410 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
