Please consider using the proper accessors to get code start as outlined below.
Thanks, -Ivan http://codereview.chromium.org/21410/diff/1/5 File src/log.cc (right): http://codereview.chromium.org/21410/diff/1/5#newcode676 Line 676: code->instruction_size() + Code::kHeaderSize); This would be much simpler if you used code->instruction_start() and code->instruction_size() instead of doing the math here. In particular if ever the Code object changes its internal layout your calculation here is off. This will also address Mikhail's comment. http://codereview.chromium.org/21410 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
