LGTM, but I would try to simplify the deferred->exit()->Bind(0) and deferred->exit()->Bind(xxx, 1) calls in codegen-ia32.cc. Maybe just extend the DeferredCode class with two new functions: BindExit() and BindExitWithResult(xxx)?
On Wed, Feb 18, 2009 at 9:58 AM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Message: > There's lots of cheesiness here, but it's simple and works. > > We should figure out a way to enforce it (in other words, catch failures > early) in debug builds. The default argument is annoying, but fits the > bill. > > Description: > Experimental: introduce a simple mechanism to allow jump targets with > backward control flows to indicate at their binding site that only the > topmost N elements need to be mergable. Aliasing and constants lower > in the frame will be as expected based on the forward control flows. > > Use the mechanism for deferred code snippets, which all fit the simple > mechanism. > > Please review this at http://codereview.chromium.org/21447 > > SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ > > Affected files: > M src/codegen-ia32.cc > M src/jump-target-arm.cc > M src/jump-target-ia32.cc > M src/jump-target.h > M src/jump-target.cc > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
