I'm actually going to hold off on putting this change in for now. It doesn't really help performance much. This is an example of a code snippet that we should consider taking off the "grid": doing manual (fixed) register allocation, preallocating the registers we'll need, and changing all the JumpTargets to raw Labels in the body.
With this change, we're not getting any values in registers that weren't there before except the iteration variable, and we're emitting a bunch of merge code to resolve our automatic register allocation decisions because they weren't fixed. On Wed, Feb 18, 2009 at 11:33 AM, <[email protected]> wrote: > LGTM > > > http://codereview.chromium.org/21446/diff/1/2 > File src/codegen-ia32.cc (right): > > http://codereview.chromium.org/21446/diff/1/2#newcode2499 > Line 2499: if (temp.reg().is(entry.reg())) { > This cannot happen because entry.reg() is spilled above before creating > temp. Assert that it can't happen. > > > http://codereview.chromium.org/21446 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
