The new guard is probably okay, but there are couple of issues that you need to fix.
http://codereview.chromium.org/20456/diff/1/2 File src/codegen-arm.cc (right): http://codereview.chromium.org/20456/diff/1/2#newcode421 Line 421: if (s->num_heap_slots() > 0 && s->calls_eval()) { Shouldn't you be declaring 's' outside the for-loop like on IA32? Does this compile at all? http://codereview.chromium.org/20456/diff/1/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/20456/diff/1/3#newcode2370 Line 2370: __ jmp(&slow); Hmm. So you always go slow case for DYNAMIC_LOCALS now? Maybe you should remove this an re-run the tests? http://codereview.chromium.org/20456 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
