Yeah, I'm not sure about that. The criteria we've been using is that anything that emits code stays in platform-specific files, because the asm interfaces are completely different. We don't even define the __ macro in the platform-independent files.
OTOH, __ bind is platform-independent and __ jmp is nearly so, so more of the jump target stuff could be shared. Especially long functions like JumpTarget::Bind that only differ in small particulars. On Thu, Feb 19, 2009 at 10:49 AM, <[email protected]> wrote: > LGTM. > > > http://codereview.chromium.org/20488/diff/1/4 > File src/jump-target-ia32.cc (right): > > http://codereview.chromium.org/20488/diff/1/4#newcode133 > Line 133: void JumpTarget::Bind(int mergable_elements) { > I don't know if it's a good idea or not, but the Bind code is almost > shareable between ARM and IA32. Maybe you should share it long term? > > > http://codereview.chromium.org/20488 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
