CodeGenerator::SmiComparison is dead code now so you should get rid of it.
Other than that, LGTM. http://codereview.chromium.org/20455/diff/1/2 File src/codegen-ia32.cc (right): http://codereview.chromium.org/20455/diff/1/2#newcode1338 Line 1338: ASSERT(left_side.is_valid()); These asserts aren't strictly necessary. They'll never fail right now. ToRegister already asserts that the result is a register before returning. http://codereview.chromium.org/20455 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
