LGTM
http://codereview.chromium.org/20491/diff/1/6 File src/debug.cc (right): http://codereview.chromium.org/20491/diff/1/6#newcode1936 Line 1936: Debugger::host_dispatch_handler_(reinterpret_cast<void*>(dispatch), why not just call dispatch with some dispatch data without this indirection? http://codereview.chromium.org/20491/diff/1/5 File src/debug.h (right): http://codereview.chromium.org/20491/diff/1/5#newcode422 Line 422: friend class DebugMessageThread; wrong indentation http://codereview.chromium.org/20491 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
