LGTM.
http://codereview.chromium.org/24023/diff/1/2 File test/mjsunit/local-load-from-eval.js (right): http://codereview.chromium.org/24023/diff/1/2#newcode38 Line 38: test("(function() { var y = 42; eval('var y = 2'); assertEquals(2, y); })();"); Maybe you should test that it works when introducing another variable (z?) with var inside the eval. I'm not quite sure if the eval('var = 2') in line 38 actually creates an extension object. http://codereview.chromium.org/24023 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
