LGTM On Thu, Feb 19, 2009 at 3:29 PM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Description: > Fixed Linux build. > > [email protected] > > Please review this at http://codereview.chromium.org/20493 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/debug.h > M test/cctest/test-debug.cc > > > Index: test/cctest/test-debug.cc > =================================================================== > --- test/cctest/test-debug.cc (revision 1318) > +++ test/cctest/test-debug.cc (working copy) > @@ -3664,8 +3664,6 @@ > > int host_dispatch_hit_count = 0; > static void HostDispatchHandlerHitCount(void* dispatch, void *data) { > - CHECK_EQ(dispatch, &HostDispatchHandlerHitCount); > - CHECK_EQ(data, &HostDispatchHandlerHitCount); > host_dispatch_hit_count++; > } > > @@ -3686,14 +3684,15 @@ > // Setup message and host dispatch handlers. > v8::Debug::SetMessageHandler(DummyMessageHandler); > v8::Debug::SetHostDispatchHandler(HostDispatchHandlerHitCount, > - &HostDispatchHandlerHitCount); > + NULL); > > // Fill a host dispatch and a continue command on the command queue before > // generating a debug break. > - v8::Debug::SendHostDispatch(&HostDispatchHandlerHitCount); > + v8::Debug::SendHostDispatch(NULL); > v8::Debug::SendCommand(buffer, AsciiToUtf16(command_continue, buffer)); > CompileRun("debugger"); > > // The host dispatch callback should be called. > CHECK_EQ(1, host_dispatch_hit_count); > -} > \ No newline at end of file > +} > + > Index: src/debug.h > =================================================================== > --- src/debug.h (revision 1318) > +++ src/debug.h (working copy) > @@ -419,7 +419,7 @@ > static v8::DebugHostDispatchHandler host_dispatch_handler_; > static void* host_dispatch_handler_data_; > > - friend class DebugMessageThread; > + friend class DebugMessageThread; > }; > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
