http://codereview.chromium.org/20534/diff/1/7
File src/platform.h (right):

http://codereview.chromium.org/20534/diff/1/7#newcode222
Line 222: static char* StrChr(const char* str, int c);
Good point removed const from the argument.

On 2009/02/20 11:20:09, Christian Plesner Hansen wrote:
> Consider making the argument non-const.  I've been bitten by passing a
string
> that shouldn't be modified into strchr and then modifying the result
-- the
> error on windows was what alerted me to it.

http://codereview.chromium.org/20534

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to