I think the approach looks right. We should make sure to come up with tests that hit all the new code paths.
http://codereview.chromium.org/21538/diff/1/2 File src/codegen-ia32.h (right): http://codereview.chromium.org/21538/diff/1/2#newcode483 Line 483: void SmiOperation(Result* operand, Make sure to put a comment in the header file mentioning whether the Result* will be consumed by the operation (in this case, I think it is). http://codereview.chromium.org/21538 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
