LGTM On Mon, Feb 23, 2009 at 10:22 AM, <[email protected]> wrote:
> Reviewers: Erik Corry, > > Description: > Even more tests of ToInt32 conversion (from Lasse). > > Please review this at http://codereview.chromium.org/28020 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M test/mjsunit/toint32.js > > > Index: test/mjsunit/toint32.js > =================================================================== > --- test/mjsunit/toint32.js (revision 1333) > +++ test/mjsunit/toint32.js (working copy) > @@ -113,3 +113,17 @@ > assertEquals(28672, toInt32(base + 29042)); > assertEquals(28672, toInt32(base + 30159)); > assertEquals(32768, toInt32(base + 31276)); > + > +// bignum is (2^53 - 1) * 2^31 - highest number with bit 31 set. > +var bignum = Math.pow(2, 84) - Math.pow(2, 31); > +assertEquals(-Math.pow(2,31), toInt32(bignum)); > +assertEquals(-Math.pow(2,31), toInt32(-bignum)); > +assertEquals(0, toInt32(2 * bignum)); > +assertEquals(0, toInt32(-(2 * bignum))); > +assertEquals(0, toInt32(bignum - Math.pow(2,31))); > +assertEquals(0, toInt32(-(bignum - Math.pow(2,31)))); > + > +// max_fraction is largest number below 1. > +var max_fraction = (1 - Math.pow(2,-53)); > +assertEquals(0, toInt32(max_fraction)); > +assertEquals(0, toInt32(-max_fraction)); > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
