LGTM. I'm happy with tackling any considerable code size increase later.
http://codereview.chromium.org/27084/diff/1002/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/27084/diff/1002/3#newcode2262 Line 2262: } else if (info == ALWAYS_FALSE) { I actually preferred to have this as a separate check before the "real" compilation of the condition. Having a break "hidden" inside here seems a bit complicated, so I'd rather have it at the beginning of the switch case. http://codereview.chromium.org/27084/diff/1002/3#newcode2350 Line 2350: break; Same here. Move ALWAYS_FALSE check to beginning of switch case? http://codereview.chromium.org/27084 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
