Starting to add unit tests for the profiler is an excelent idea. However I think you can simplify the tests, and make them platform independent. The current approach only works your IA32, and having tests that works on all (both) platforms is preferred. If this for some reason is not possible there should be different .cc files like for test-assembler-*.
Instead of using code patching to get the FP how about adding a runtime function Runtime_GetFP to return the FP of the calling JS function like Runtime_DebugPrint where the FP of the caller is printed? This could then be called with %GetFP in the test function. On 2009/02/25 10:42:32, Mikhail Naganov wrote: http://codereview.chromium.org/28112 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
