Drive by comments. -Ivan
http://codereview.chromium.org/27128/diff/1/5 File src/parser.cc (right): http://codereview.chromium.org/27128/diff/1/5#newcode1269 Line 1269: if (assignment->op() != Token::ASSIGN) return false; You check here that only ASSIGN statements are added when the block continues, but you do not check for the initial node to be an ASSIGN statement anywhere I can tell. http://codereview.chromium.org/27128/diff/1/5#newcode1304 Line 1304: bool InitializationBlockFinder::SameObject(Expression* e1, Expression* e2) { What made you put this method outside the class declaration? Since this is a private class I would just put all of the code in the declaration, or at least pull all non-trivial (aka 1-liners) out to be consistent. http://codereview.chromium.org/27128/diff/1/5#newcode1307 Line 1307: if (v1 != NULL && v2 != NULL) { In general I find code more readable when () are added around boolean expressions such as if ((v1 != NULL) && (v2 != NULL)) http://codereview.chromium.org/27128 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
