LGTM.
http://codereview.chromium.org/27133/diff/1/22 File src/accessors.cc (right): http://codereview.chromium.org/27133/diff/1/22#newcode391 Line 391: Heap::arguments_symbol()); Indentation is slightly off here. http://codereview.chromium.org/27133/diff/1/6 File src/macro-assembler-arm.h (right): http://codereview.chromium.org/27133/diff/1/6#newcode233 Line 233: Handle<Object> CodeObject() { Fits on one line? http://codereview.chromium.org/27133/diff/1/21 File src/macro-assembler-ia32.h (right): http://codereview.chromium.org/27133/diff/1/21#newcode238 Line 238: Handle<Object> CodeObject() { Fits on one line? http://codereview.chromium.org/27133/diff/1/34 File src/stub-cache.h (right): http://codereview.chromium.org/27133/diff/1/34#newcode370 Line 370: HandleScope scope_; This should allow you to get rid of a lot of HandleScopes inside the GenerateXXX functions. http://codereview.chromium.org/27133 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
