Author: [email protected]
Date: Thu Feb 26 00:05:03 2009
New Revision: 1373
Modified:
branches/bleeding_edge/src/stub-cache-arm.cc
branches/bleeding_edge/src/stub-cache-ia32.cc
Log:
Follow on to r1368: Remove unnecessary HandleScope in the StubCompilers.
Review URL: http://codereview.chromium.org/27156
Modified: branches/bleeding_edge/src/stub-cache-arm.cc
==============================================================================
--- branches/bleeding_edge/src/stub-cache-arm.cc (original)
+++ branches/bleeding_edge/src/stub-cache-arm.cc Thu Feb 26 00:05:03 2009
@@ -466,8 +466,6 @@
// -- lr: return address
// -----------------------------------
- HandleScope scope;
-
// Enter an internal frame.
__ EnterInternalFrame();
@@ -500,8 +498,6 @@
// ----------- S t a t e -------------
// -- lr: return address
// -----------------------------------
-
- HandleScope scope;
Label miss;
const int argc = arguments().immediate();
@@ -553,8 +549,6 @@
// ----------- S t a t e -------------
// -- lr: return address
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the receiver from the stack
@@ -675,8 +669,6 @@
// ----------- S t a t e -------------
// -- lr: return address
// -----------------------------------
-
- HandleScope scope;
Label miss;
// TODO(1224669): Implement.
@@ -701,8 +693,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the receiver from the stack.
@@ -735,8 +725,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the object from the stack.
@@ -791,8 +779,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the object from the stack.
@@ -845,8 +831,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ ldr(r0, MemOperand(sp, 0));
@@ -868,8 +852,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ ldr(r0, MemOperand(sp, 0));
@@ -890,8 +872,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ ldr(r0, MemOperand(sp, 0));
@@ -913,8 +893,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ ldr(r0, MemOperand(sp, 0));
@@ -939,7 +917,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ ldr(r2, MemOperand(sp, 0));
@@ -965,7 +942,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ ldr(r2, MemOperand(sp, 0));
@@ -992,7 +968,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
// Check the key is the cached one
@@ -1019,7 +994,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
// Check the key is the cached one
@@ -1043,7 +1017,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
// Check the key is the cached one
@@ -1067,8 +1040,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
-
Label miss;
__ IncrementCounter(&Counters::keyed_load_string_length, 1, r1, r3);
@@ -1095,7 +1066,6 @@
// -- sp[0] : key
// -- sp[4] : receiver
// -----------------------------------
- HandleScope scope;
GenerateLoadMiss(masm(), Code::KEYED_LOAD_IC);
return GetCode(CALLBACKS);
@@ -1112,7 +1082,6 @@
// -- lr : return address
// -- [sp] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ IncrementCounter(&Counters::keyed_store_field, 1, r1, r3);
Modified: branches/bleeding_edge/src/stub-cache-ia32.cc
==============================================================================
--- branches/bleeding_edge/src/stub-cache-ia32.cc (original)
+++ branches/bleeding_edge/src/stub-cache-ia32.cc Thu Feb 26 00:05:03 2009
@@ -448,8 +448,6 @@
// TODO(1241006): Avoid having lazy compile stubs specialized by the
// number of arguments. It is not needed anymore.
Object* StubCompiler::CompileLazyCompile(Code::Flags flags) {
- HandleScope scope;
-
// Enter an internal frame.
__ EnterInternalFrame();
@@ -476,8 +474,6 @@
int index) {
// ----------- S t a t e -------------
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the receiver from the stack.
@@ -528,8 +524,6 @@
CheckType check) {
// ----------- S t a t e -------------
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the receiver from the stack.
@@ -649,8 +643,6 @@
String* name) {
// ----------- S t a t e -------------
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the number of arguments.
@@ -729,8 +721,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the object from the stack.
@@ -765,8 +755,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the object from the stack.
@@ -821,8 +809,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
// Get the object from the stack.
@@ -878,7 +864,6 @@
// -- esp[4] : key
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ IncrementCounter(&Counters::keyed_store_field, 1);
@@ -920,8 +905,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -942,8 +925,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -965,8 +946,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
-
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -987,7 +966,6 @@
// -- esp[0] : return address
// -- esp[4] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1009,7 +987,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1039,7 +1016,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1070,7 +1046,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1099,7 +1074,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1128,7 +1102,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1155,7 +1128,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
@@ -1182,7 +1154,6 @@
// -- esp[4] : name
// -- esp[8] : receiver
// -----------------------------------
- HandleScope scope;
Label miss;
__ mov(eax, (Operand(esp, kPointerSize)));
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
