LGTM.
http://codereview.chromium.org/27200/diff/16/1012 File src/codegen-ia32.cc (right): http://codereview.chromium.org/27200/diff/16/1012#newcode2168 Line 2168: Could you put a comment here, indicating the possible states of (1) fallthrough links to and from the default clause (2) fallthrough link to remaining cases, that are only reached by fallthrough (3) next_test link to the default clause, as bound fallthrough or as linked target. http://codereview.chromium.org/27200/diff/16/1012#newcode2174 Line 2174: VisitStatements(cases->at(index)->statements()); Should you break on no frame here, or is VisitStatements guarded by a sufficiently fast check for a valid frame? http://codereview.chromium.org/27200/diff/16/1012#newcode2180 Line 2180: // The last clause compiled was unconditionally true. We still The last test compiled? Can't many fall-through clauses be compiled after this test? http://codereview.chromium.org/27200 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
