LGTM.
http://codereview.chromium.org/27269/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/27269/diff/1/2#newcode1634 Line 1634: ASSERT((obj_size % Code::kCodeAlignment) == 0); IsAligned(obj_size, Code::kCodeAlignment) would be easier to read. http://codereview.chromium.org/27269/diff/1/2#newcode1669 Line 1669: return code; It would be nice if you could assert that the entry point (instruction start) is aligned the way you want it. http://codereview.chromium.org/27269/diff/1/3 File src/objects.h (right): http://codereview.chromium.org/27269/diff/1/3#newcode2282 Line 2282: static const int kFiller6Offset = kKindSpecificFlagsOffset + kIntSize; Comment on why you need fillers here? http://codereview.chromium.org/27269 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
