Reviewers: Mads Ager, Description: Check the return value of fwrite.
Newer versions of glib stdio mark fwrite() with warn_unused_result Please review this at http://codereview.chromium.org/27305 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/log.cc Index: src/log.cc =================================================================== --- src/log.cc (revision 1370) +++ src/log.cc (working copy) @@ -380,7 +380,8 @@ // Write the log message to the log file currently opened. void LogMessageBuilder::WriteToLogFile() { ASSERT(pos_ <= Logger::kMessageBufferSize); - fwrite(Logger::message_buffer_, 1, pos_, Logger::logfile_); + size_t rv = fwrite(Logger::message_buffer_, 1, pos_, Logger::logfile_); + ASSERT(rv == pos_); } #endif --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
