Done and done. On Mon, Mar 2, 2009 at 11:16 AM, <[email protected]> wrote:
> Small comments as discussed, otherwise LGTM. > > -Ivan > > > > > http://codereview.chromium.org/28296/diff/12/14 > File src/codegen-ia32.cc (right): > > http://codereview.chromium.org/28296/diff/12/14#newcode2103 > Line 2103: // Compile case bodies as needed. > ASSERT that you do not have a valid frame here and comment why this is > so. > > http://codereview.chromium.org/28296/diff/12/14#newcode2132 > Line 2132: } > Add else case here for the only fall-through case with an ASSERT. > > > http://codereview.chromium.org/28296 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
