Reviewers: Lasse Reichstein, Description: Fox borken assert on ARM.
Please review this at http://codereview.chromium.org/40003 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/objects-debug.cc Index: src/objects-debug.cc =================================================================== --- src/objects-debug.cc (revision 1399) +++ src/objects-debug.cc (working copy) @@ -698,15 +698,20 @@ case JSRegExp::IRREGEXP: { FixedArray* arr = FixedArray::cast(data()); Object* ascii_data = arr->get(JSRegExp::kIrregexpASCIICodeIndex); + Object* uc16_data = arr->get(JSRegExp::kIrregexpUC16CodeIndex); +#ifdef ARM + ASSERT(ascii_data->IsTheHole() || ascii_data->IsByteArray()); + ASSERT(uc16_data->IsTheHole() || uc16_data->IsByteArray()); +#else ASSERT(ascii_data->IsTheHole() || (FLAG_regexp_native ? ascii_data->IsCode() : ascii_data->IsByteArray())); - Object* uc16_data = arr->get(JSRegExp::kIrregexpUC16CodeIndex); ASSERT(uc16_data->IsTheHole() || (FLAG_regexp_native ? uc16_data->IsCode() : uc16_data->IsByteArray())); +#endif ASSERT(arr->get(JSRegExp::kIrregexpCaptureCountIndex)->IsSmi()); ASSERT(arr->get(JSRegExp::kIrregexpMaxRegisterCountIndex)->IsSmi()); break; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
