Reviewers: Søren Gjesse, Kasper Lund, Message: Kasper, please look at this CL as Søren said that you wrote some of stack unwinding code before.
Description: Dump more stack frames to perf log when executing a C++ function. JavaScriptFrameIterator is templatized on the iterator type and renamed to JavaScriptFrameIteratorTemp. The original JSFI is now a typedef for JavaScriptFrameIteratorTemp<StackFrameIterator>. Because of templatizing, JSFI code is moved to frames-inl.h StackTraceFrameIterator moved to frames.* Implemented SafeStackFrameIterator which wraps StackFrameIterator and have the same interface. It performs additional checks of stack addresses prior to delegating to StackFrameIterator. SafeSFI is used in an another specialization of JavaScriptFrameIteratorTemp template to perform safe JS frames iteration on sampler ticks. I haven't took an advantage of having multiple stack frames in tickprocessor yet. Please review this at http://codereview.chromium.org/39009 Affected files: M src/frames-inl.h M src/frames.h M src/frames.cc M src/log.h M src/log.cc M src/platform.h M src/top.cc M test/cctest/test-log-ia32.cc --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
